-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several possible bugs #12
Comments
we appreciate your suggestions for the toolkit!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've been using this codebase to handle some new datasets, it did help me a lot, but I found a few places where there might be bugs or unclear descriptions.
there might be bugs in processing " from_prefix_to_infix" and "from_infix_to_prefix" in the preprocessing tools:
If you try to map this equation to prefix and map it back:
1500/(((100+12)-(100-12))/100)
it will yield this, where the relation between 100+12 and 100-12 is not correct.
1500/(100+12-100-12)/100
and for */, it would ignore () as well:
1/(1-(1/(2*2))) would be mapped to 1/(1-1/2*2)
Another small problem, every time when feeding a batch, it will re-preprocess the data. This would include much redundant computation if we run many epochs.
Thanks again for this tool!
The text was updated successfully, but these errors were encountered: