Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The automatically switching smart system: "under" vs "over" #2

Open
alexipavlenko opened this issue Apr 9, 2018 · 1 comment
Open

Comments

@alexipavlenko
Copy link

alexipavlenko commented Apr 9, 2018

documentation

data_position | (string)

Specifies where elements data will be shown. Available modes are:
over (over element)
under (under element)
rside (on right side)
lside (on left side)

Please note lightbox uses a smart system automatically switching to "over" as soon element becomes too small because of long texts or tiny window.

So, "lightbox uses a smart system automatically switching to "over" as soon element becomes too small because of long texts or tiny window".

I propose the automatically switching to "under" and leave (do not delete) this text description on very small screens. It looks ok. On the other hand, it's better, when a user will decide, which the switching mode to use (on small screens).

@LCweb-ita
Copy link
Owner

Hello,
the "under" layout is pretty complex since involves a lot of sizing tricks (in fact the text could be higher if the image is smaller and then I'd have to recalculate everything over and over again).

Finally, "text under" on mobile means a super tall lightbox and a tiny image. The "over" layout is surely the best on mobile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants