Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Official Type Definitions #63

Open
ghost opened this issue Oct 10, 2021 · 1 comment
Open

Provide Official Type Definitions #63

ghost opened this issue Oct 10, 2021 · 1 comment
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Oct 10, 2021

Description

I'm using unofficial @types/lambda-log package, and it seems to be incorrect or outdated.
For example, in the options object, it doesn't show me tagsKey and messageKey properties, however, when I look from the source code they are defined, and can be set.

It would be better if the repository is re-written in TypeScript, or provides its own type definitions.
...

Why should Lambda Log incorporate this feature?

TypeScript requires type definitions for a package/module, and since this package does not officially provide it, unofficial @types/lambda-log is used, and they are outdated, or incorrect. That's why the package should ship with its own type definitions.
...

@ghost ghost added the enhancement label Oct 10, 2021
@KyleRoss KyleRoss added this to the v4.0.0 milestone Oct 11, 2021
@KyleRoss KyleRoss self-assigned this Oct 11, 2021
@KyleRoss
Copy link
Owner

I've noticed there has been a discrepancy with the type definitions. I, unfortunately, did not create them and would prefer to pull the types into the repository as you have mentioned.

I'm in the progress of building v4.0.0 now in TypeScript to solve for this issue :)

This was referenced Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant