Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Split the calculation of the inputs for the utility functions for element matrices and the calling of the functions #12319

Open
rfaasse opened this issue Apr 26, 2024 · 0 comments · Fixed by #12334, #12341, #12338, #12337 or #12361
Assignees

Comments

@rfaasse
Copy link
Contributor

rfaasse commented Apr 26, 2024

As a developer I would like to split the calculation of inputs and calling of functions, such that I can refactor the functions to calculate the relevant matrices for the entire element at once, instead of for each integration point individually.

Background
The created utility functions CalculatePermeabilityMatrix, CalculateCouplingMatrix and CalculateCompressibilityMatrix currently calculate the contribution of a single integration point in the element. This should change to calculate the matrix contributions of all integration points at once.

This means the utility functions need to get their inputs for all integration points at once (in form of a list/vector). This issue aims to create these lists to enable that refactor step later on. Note this means that the utility function signatures will not be changed in this issue.

Acceptance criteria
In all places where the CalculatePermeabilityMatrix, CalculateCouplingMatrix and CalculateCompressibilityMatrix are called, the input lists should be calculated in a separate loop.

Successor #12320

@rfaasse rfaasse reopened this May 2, 2024
@rfaasse rfaasse reopened this May 10, 2024
@rfaasse rfaasse reopened this May 16, 2024
@rfaasse rfaasse reopened this May 24, 2024
@rfaasse rfaasse reopened this May 29, 2024
@rfaasse rfaasse linked a pull request May 29, 2024 that will close this issue
@rfaasse rfaasse reopened this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment