-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPv6 encoding incorrect #704
Comments
Forgot to mention: I'll leave that system up for a week or so, so you can see the problem for yourself and we can easily test a fix. I could add an ssh key (one of these? https://github.com/Kovah.keys) if you'd like to poke around yourself |
Why am I doing this to myself 😭 An add-on to delete cookies after closing the tab now pops an error onto my screen every few minutes. Maybe that's what I had (Edit: for the record, nothing a little |
Thanks for the very detailed report. I will have a look at the parsing of URLs containing v6 IPs. But all the other stuff... well you mentioned it: the world is not ready yet. I can't understand how a dominating platform like Github does not support incoming IPv6 traffic... |
I tested #703 on a fresh server and chose not to buy an IPv4 address because, well, we're out and reusing someone else's costs extra nowadays.
Address encoding issue 1
(Note: if you see red highlighted lines, that's github's broken http syntax parsing or something, not me trying to indicate where the error is. It seems to think that HTTP has only headers, no status line or body!)
Address encoding issue 2
document.querySelector('meta[property="la-app-data"]')
returnsnull
fromresources/assets/js/components/Base.js
, not sure what that's used for<a href='http://%5B2a01:4f8:c17:cfd5::1%5D/setup/requirements'>
All other links are also broken, for example the main menu on the guest page.
Installation issue
The documentation instructs one to "Download the LinkAce .zip package from the release page."
Linkace.org and demo.linkace.org work perfectly fine via the v6-only connection (tested by using
ssh -D 0:8080
with that IPv6-only server and configuring that as socks5+dns proxy in Firefox), so those could be used as distribution method.As an aside, the zip structure is a bit convoluted:
linkace-v1.12.2.zip
contains another zip file calledlinkace.zip
which contains a tarbomb (all files in.
rather than in a subdirectory). I don't know about others, but for me it would be more expected to have the files contained in a subdirectory of the zip that one downloads.Link adding issue
/etc/hosts
and navigate to the link adding page at e.g. http://linkacetest6.local/links/createhttp://[2a01:4f8:c17:cfd5::1]/
as the link and try to add itThe errors may stem from the same code:
[]
are incorrectly encoded somewhere. Where and why this happens, I don't know how to easily find out. For the first two encoding issues, a solution-by-simplification may be to just use relative URLs instead of trying to add unnecessary details to links, but that would still leave the link adding problemLinkAce version: dev
Setup Method: PHP
Operating System: Debian Bookworm
The text was updated successfully, but these errors were encountered: