Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy support for match info web-service #757

Open
margaretha opened this issue Jun 5, 2024 · 3 comments
Open

Remove legacy support for match info web-service #757

margaretha opened this issue Jun 5, 2024 · 3 comments
Labels
API v1.1. postponed
Milestone
API v1.1

Comments

@margaretha
Copy link
Contributor

The old web-service for match info was

@Path("{version}/corpus/{corpusId}/{docId}/{textId}/{matchId}/matchInfo")

which has been moved to

@Path("{version}/corpus/{corpusId}/{docId}/{textId}/{matchId}").

The old path has been deprecated for years. Can we safely remove it?
@margaretha margaretha added this to the 0.73.2 milestone Jun 5, 2024
idsgerrit pushed a commit that referenced this issue Jun 5, 2024
@margaretha
Updated tests using the old match info web-services (#757)
d709be5 
Change-Id: Ic02bd5137860b592e15617ac61bd70a65e4cd3cd
idsgerrit pushed a commit that referenced this issue Jun 5, 2024
Create change
2c7429c 
Uploaded patch set 1.

Patch-set: 1
Change-id: Ic02bd5137860b592e15617ac61bd70a65e4cd3cd
Subject: Updated tests using the old match info web-services (#757)
Branch: refs/heads/master
Status: new
Topic: 
Commit: d709be5
Tag: autogenerated:gerrit:newPatchSet
Groups: d709be5
Private: false
Work-in-progress: false
@Akron
Copy link
Member

Akron commented Jun 5, 2024

Where was this information published? Sorry - Kalamar still uses the old format. I guess the deprecation warning was not drastically enough ... will remove it.

idsgerrit pushed a commit that referenced this issue Jun 5, 2024
@margaretha
Added deprecation warning for the old matchInfo service (#757)
e6d59b0 
Change-Id: I07309f7dba50916bfff10ad6a75f9f73592ae7c3
idsgerrit pushed a commit that referenced this issue Jun 5, 2024
Create change
5c45001 
Uploaded patch set 1.

Patch-set: 1
Change-id: I07309f7dba50916bfff10ad6a75f9f73592ae7c3
Subject: Added deprecation warning for the old matchInfo service (#757)
Branch: refs/heads/master
Status: new
Topic: 
Commit: e6d59b0
Tag: autogenerated:gerrit:newPatchSet
Groups: e6d59b0
Private: false
Work-in-progress: false
idsgerrit pushed a commit that referenced this issue Jun 5, 2024
@margaretha
Added deprecation warning for the old matchInfo service (#757)
c7f8f80 
Change-Id: I07309f7dba50916bfff10ad6a75f9f73592ae7c3
idsgerrit pushed a commit that referenced this issue Jun 5, 2024
Create patch set 2
72e6483 
Uploaded patch set 2.

Patch-set: 2
Subject: Added deprecation warning for the old matchInfo service (#757)
Commit: c7f8f80
Tag: autogenerated:gerrit:newPatchSet
Groups: c7f8f80
@margaretha margaretha removed this from the 0.73.2 milestone Jun 5, 2024
@margaretha
Copy link
Contributor Author

Sorry Kustvakt didn't give a warning for deprecation. I have added that in c7f8f80.

This issue is postponed.

@Akron
Copy link
Member

Akron commented Jun 12, 2024

Change applied in Kalamar 0.54.

@margaretha margaretha added this to the API v1.1 milestone Jun 19, 2024
@margaretha margaretha mentioned this issue Jun 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API v1.1. postponed
Projects
None yet
Milestone
API v1.1
Development

No branches or pull requests
2 participants
@Akron @margaretha