Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryContextRewrite #755

Open
margaretha opened this issue May 27, 2024 · 0 comments
Open

QueryContextRewrite #755

margaretha opened this issue May 27, 2024 · 0 comments
Assignees
Milestone

Comments

@margaretha
Copy link
Contributor

Maximum token context should be configurable in Kustvakt as described in #745. It should be implemented in Kustvakt as a rewrite that overrides the context when the requested size is larger than the maximum.

Where should the rewrite notes be placed?

  1. Within context
"meta" : {
    "context" : {
      "left" : [ "token", 40 ],
      "right" : [ "token", 40 ],
      "rewrites" : [ {
        "@type" : "koral:rewrite",
        "src" : "Kustvakt",
        "operation" : "operation:override",
        "scope" : "left(60)"
      }, {
        "@type" : "koral:rewrite",
        "src" : "Kustvakt",
        "operation" : "operation:override",
        "scope" : "right(60)"
      } ]
    },
    "tokens" : false,
    "snippets" : true,
    "timeout" : 10000
  }
  1. Within meta
{
  "meta" : {
    "context" : {
      "left" : [ "token", 40 ],
      "right" : [ "token", 40 ]
    },
    "tokens" : false,
    "snippets" : true,
    "timeout" : 10000,
    "rewrites" : [ {
      "@type" : "koral:rewrite",
      "src" : "Kustvakt",
      "operation" : "operation:override",
      "scope" : "context-left(60)"
    }, {
      "@type" : "koral:rewrite",
      "src" : "Kustvakt",
      "operation" : "operation:override",
      "scope" : "context-right(60)"
    } ]
  },
@margaretha margaretha added this to the 0.73.2 milestone May 27, 2024
idsgerrit pushed a commit that referenced this issue May 28, 2024
Uploaded patch set 1.

Patch-set: 1
Change-id: I14f62131063c114acdfa5cb3cb6f9eeff169d6cb
Subject: Implemented QueryContextRewrite (#755)
Branch: refs/heads/master
Status: new
Topic: 
Commit: 1037007
Tag: autogenerated:gerrit:newPatchSet
Groups: 1037007
Private: false
Work-in-progress: false
idsgerrit pushed a commit that referenced this issue May 28, 2024
Change-Id: I14f62131063c114acdfa5cb3cb6f9eeff169d6cb
idsgerrit pushed a commit that referenced this issue Jun 6, 2024
Uploaded patch set 2.

Patch-set: 2
Subject: Implemented QueryContextRewrite (#755)
Commit: 21b1098
Tag: autogenerated:gerrit:newPatchSet
Groups: 21b1098
idsgerrit pushed a commit that referenced this issue Jun 6, 2024
Change-Id: I14f62131063c114acdfa5cb3cb6f9eeff169d6cb
@margaretha margaretha modified the milestones: 0.73.2, 0.73.3 Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants