Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visible lag opening folders in new version, as compared to older version (suspicious fetch logs) #7357

Closed
1 task done
navin09 opened this issue May 2, 2024 · 4 comments
Closed
1 task done
Labels
B-bug Bug: general classification B-performance Bug: performance issues S-verified Status: Verified by maintainer

Comments

@navin09
Copy link

navin09 commented May 2, 2024

Expected Behavior

  • Clicking a 'folder' is responsive (time between action and response is within 350ms)
  • Clicking a 'folder' to open it should not trigger a fetch to an internet resource of any kind.

Actual Behavior

Reproduction Steps

  1. Open Insomnia
  2. Open a Collection
  3. Click on any 'folder'

Is there an existing issue for this?

Additional Information

Version of Insomnia which works as intended:
Version: Insomnia 2023.1.0
Build date: 3/9/2023
OS: Linux x64 5.15.0-105-generic
Electron: 22.0.0
Node: 16.17.1
V8: 10.8.168.20-electron.0
Architecture: x64

Version of Insomnia which exhibits the bug:
Version: Insomnia 9.1.0
Build date: 4/30/2024
OS: Linux x64 5.15.0-105-generic
Electron: 29.3.0
Node: 20.9.0
Node ABI: 121
V8: 12.2.281.27-electron.0
Architecture: x64

Insomnia Version

9.1.0

What operating system are you using?

Other Linux

Operating System Version

Linux Mint 21.2 (Based on Ubuntu 22.04)

Installation method

Portable AppImage

Last Known Working Insomnia version

2023.1.0

@navin09 navin09 added B-bug Bug: general classification S-unverified Status: Unverified by maintainer labels May 2, 2024
@jackkav jackkav added S-verified Status: Verified by maintainer B-performance Bug: performance issues and removed S-unverified Status: Unverified by maintainer labels May 2, 2024
@jackkav
Copy link
Contributor

jackkav commented May 2, 2024

3 of these 4 requests are cached on the client, but its true we do need a better story for the /graphql endpoint reloading.

@navin09
Copy link
Author

navin09 commented May 2, 2024

3 of these 4 requests are cached on the client, but its true we do need a better story for the /graphql endpoint reloading.

@jackkav thanks for the reply. If they are cached on the client, why make the fetch at all every time a folder is clicked? Also, this doesn't seem to happen in the older version (2023.1.0) If you want to keep the list of folders updated with a remote resource, maybe using a websocket connection that notifies of any updates or changes would be a better solution, no?

@Plucks77
Copy link

Plucks77 commented May 2, 2024

For me is the same, opening and closing folders takes a long time, so I need to hit command + r. In general the UI is very laggy compared to previous versions...

@jackkav
Copy link
Contributor

jackkav commented May 8, 2024

Over fetching is addressed in 9.1.1. My previous assertion was incorrect there were fetches being made. We recently improved our app fetching observability so we are doing our best to address some of the performance issues now we have a faster learning loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: general classification B-performance Bug: performance issues S-verified Status: Verified by maintainer
Projects
None yet
Development

No branches or pull requests

4 participants