-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why defaults don't match the github doc? #799
Comments
Changing this would be a breaking change, so I don't think we should. |
Ok thanks we can close this issue. |
It would indeed be a BC break to change that value now, but maybe a better solution is to move these options into a parameters/options parameter of the function and leave all option empty by default so they will fallback to github defaults. I will assign the 3.0 milestone to this issue, so we can handle this possible cleanup in the future! |
For example current user api handler link in
type
field hasowner
value as default but according github api we link haveall
as default.P.S If necessary, I can fix it by PR.
Thanks for this awesome library.
The text was updated successfully, but these errors were encountered: