Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically inject the menus into the container #466

Open
tacman opened this issue Oct 26, 2023 · 2 comments
Open

Automatically inject the menus into the container #466

tacman opened this issue Oct 26, 2023 · 2 comments

Comments

@tacman
Copy link
Contributor

tacman commented Oct 26, 2023

The only reason that builder class is marked as the easy way is because of needing to manually wire the menu as a service in services.yaml. This step could be eliminated by adding an attribute (as @stof mentions in #464 ) and automatically wire and configure the service during the bundle configuration.

I'd be able to help with something like this if we simplified the bundle setup that was introduced in Symfony 6.1

@stof
Copy link
Collaborator

stof commented Oct 26, 2023

I have a partial implementation locally already for the attribute. I started the work yesterday evening.

@simondaigre
Copy link

Hi @stof, I'm quite interested by this feature.
Could you share your implementation ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants