-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add strict check for BuilderAliasProvider #327
Comments
ah, and providers have no priority. that is a pitty, otherwise you could just put your provider first. i think adding a priority option to the container tag should be easy, do you want to do a pull request for that? @stof is there a problem with the regular expression @vudaltsov proposes? could it lead to things not being accepted that are supposed to be accepted? |
I am happy to make a PR on whatever you decide. |
lets see if @stof says something.
if you want to do the priorities, i would feel confident enough to
review and merge that. for the preg_match, i am more afraid of side
effects and would want input from stof.
|
I have a bundle which uses
bundle:path:file.yml
syntax. But since the requirements in BuilderAliasProvider are not strict enough (2 == substr_count($name, ':')
), my custom Provider is not reached by the ChainProvider.I suggest checking for smth like:
The text was updated successfully, but these errors were encountered: