-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heatmap might destroy layout if viewinghistory covers more than 2 years #1
Comments
I just tested out with 4 years, and a lot of it seems off. Btw, this is awesome! |
Instead of the picture if you have any test data available it would be helpful (gist or pastebin) but not strictly necessary. To fix this creating data that covers multiple years is a necessity which will show me whats off :-) https://stackoverflow.com/a/13868457/3244464 could be helpful to determine the actual height of the created heatmap chart. Everything after Line 576 in will need to be pushed down accordingly. Maybe it's time to move away from "npc" units and use pixels instead? |
Here is a gist: https://gist.github.com/CGraabaek/41f3143b695e1b9e2d3101075ae8f94d. I noticed that the CSV is a little off, since Netflix allows commas in the the title of TV show episodes, so it thinks there are more columns than there actually is. It's really nice that you will look into it. :) |
The movies and episodes parsing isn't spot on. I was and am aware that this is actually one of the weak points of this code (the project was hacked together in a day so not much consideration to put there ;) ). Sometimes movies include commas, sometimes they don't. Series information usually includes numbers, but sometimes someone gets fancy and they break the rule. leading and trailing quotes inside the title and so on and on. |
If the viewing history covers more than a single year the heatmap might take up too much space for the current layout.
Not yet tested but I'll do so in the future. We can check if this is the case and move the icons and text accordingly.
The text was updated successfully, but these errors were encountered: