Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to NPM #68

Open
NT-Christ opened this issue Dec 30, 2016 · 13 comments
Open

Add to NPM #68

NT-Christ opened this issue Dec 30, 2016 · 13 comments

Comments

@NT-Christ
Copy link

Please add this package to NPM so we can all auto update it from npm.

Thanks!

@benjamin-albert
Copy link
Collaborator

@NT-Christ Good idea.

@KidSysco Can you create a user on NPM and publish a package?

I already did this once if you need help feel free to reach me on Slack.

@KidSysco
Copy link
Owner

Yea sorry, I got tied up with the holidays, getting back into the swing of things now. I will keep you posted.

@benjamin-albert
Copy link
Collaborator

@KidSysco Any chance you can take a look at this.

Tell me if you'd prefer I publish the plugin to NPM.

@KidSysco
Copy link
Owner

KidSysco commented Feb 8, 2017

I am glad you brought this up. I did look at it and I was not very interested in messing with it.

It looks like it will change the way we deploy builds and tags a bit. I was not sure we needed another dependency like this just because some folks wish to use NPM for client tools.

I admit it would be a fair offering, but I am just not sure how many folks are really interested in this.

If you want to do it, I am OK with it, just be sure to update the wiki docs about how to develop and deploy once you have decided on a methodology.

Let me know what you think.

@benjamin-albert
Copy link
Collaborator

benjamin-albert commented Feb 8, 2017

This adds a few simple steps to deployment that can be automated using Travis-CI:

  1. Bump the version in the package.json by running npm version patch (which I anyway do manually when I bump the version in the JS file).
  2. Run npm publish

Take a look at npm Releasing - Travis CI which you can setup to do this automatically when we add a release on GitHub.

@benjamin-albert
Copy link
Collaborator

I've been involved in a few projects that use npm for front-end dependencies and since then I've been expecting this feature request.

I also expect more projects to prefer have only one dependency manager instead of two.

@benjamin-albert
Copy link
Collaborator

@KidSysco If you don't want to deal with setting this up, just tell me. Feel free to reach me on Slack.

@KidSysco
Copy link
Owner

KidSysco commented Feb 9, 2017

Having never done this, or had the need. I am not comfortable with it or what it will do to the release process. When reading through the docs, I started to get confused about how to tag and release and that bothered me. So I lost interest. I was not going to do it without your approval either. No matter what happens here, we both need to be able to conduct a release.

If you want to do it, then I am OK with it. The only thing I ask is that you update the docs so that I can understand how to tag a release properly in the future. I am sure you were going to do that anyway.

It sounds like some folks out there might appreciate this. Which is a good thing. So I suppose I would appreciate it if you wanted to take it on and then teach me how it all works when you are done.

@KidSysco
Copy link
Owner

KidSysco commented Feb 9, 2017

I never thought of integrating this with Travis CI either. That is a really good idea.

@benjamin-albert
Copy link
Collaborator

OK I'll publish the plugin to NPM.

Once I setup Travis-CI the release process should be identical to our current steps to release (run grunt + make a release on GitHub).

I'll still add a document explaining how to make a release.

@andrechalom
Copy link

Hi! I've tried installing this package with npm install --save jquery-ui-month-picker, but it fails if bower is not installed:

npm ERR! [email protected] postinstall: bower install
npm ERR! spawn ENOENT

Is this expected?

@KidSysco
Copy link
Owner

I don't think the NPM integration is working. Just use the normal install guides for now.

https://github.com/KidSysco/jquery-ui-month-picker/wiki

This was referenced Jun 17, 2018
@ojathelonius
Copy link

To make it work, package.json should have the proper entry file :

"main": "src/MonthPicker.js",

The post-install command and bower devDependency are not required for npm, and the library can then be imported with :

import 'jquery-ui-month-picker';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants