-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shaders don't mark any exposed properties as "Main Color" #714
Comments
Thanks — the ShaderGraphs in UnityGltf were compatible back to 2019.x where that didn’t exist, but now that we support 2021.x+ it’s a good idea to add that. Worth noting that
is a bit of a misnomer, code that doesn’t check it is already broken, not every shader even has a main color. |
@pfcDorn we should also add to the docs that shader properties in UnityGltf always match their glTF spec names for ease of use |
This breaks any code that uses "someMaterial.color" without checking and forces implementation of code paths specifically for UnityGLTF materials.
The text was updated successfully, but these errors were encountered: