Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openxr_platform.h should include unknwn.h for IUnknown on WIN32 #326

Open
amalon opened this issue Aug 25, 2022 · 1 comment
Open

openxr_platform.h should include unknwn.h for IUnknown on WIN32 #326

amalon opened this issue Aug 25, 2022 · 1 comment
Labels
synced to gitlab Synchronized to OpenXR internal GitLab

Comments

@amalon
Copy link

amalon commented Aug 25, 2022

Issue #237 was worked around for the SDK build, but the same issue still affects users of the OpenXR headers. unknwn.h needs to be included before openxr_platform.h for WIN32 platform to avoid build errors reported with MSVC 2019 (16.11.18), with OpenXR 1.0.24:
https://sourceforge.net/p/flightgear/mailman/message/37697116/
Visual studio community 2022 doesn't seem affected.

This is wrong. OpenXR apps shouldn't be expected to anticipate includes that might be required on windows for extensions they don't use or for future extensions they may not know about. There doesn't seem to be any indication in the XR spec that I can find that other includes are required prior to openxr_platform.h.

openxr_platform.h needs fixing to include necessary headers itself, which are reportedly marked up in the XML but not being written out.

@rpavlik-bot rpavlik-bot added the synced to gitlab Synchronized to OpenXR internal GitLab label Sep 7, 2022
@rpavlik-bot
Copy link
Collaborator

An issue (number 1817) has been filed to correspond to this issue in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#1817 ), to facilitate working group processes.

This GitHub issue will continue to be the main site of discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
synced to gitlab Synchronized to OpenXR internal GitLab
Projects
None yet
Development

No branches or pull requests

2 participants