-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DiscreteUpdater does not take isterminal into account #471
Comments
This isn't an issue if the observation function is defined correctly, right? In for (sp, tp) in weighted_iterator(td)
spi = stateindex(pomdp, sp)
op = obs_weight(pomdp, s, a, sp, o)
bp[spi] += op * tp * b.b[si]
end My thoughts are if we aren't expecting an observation if Is there a case you saw or were thinking of where this isn't the case? |
I think solvers, belief updaters, and simulators should avoid calling |
That makes sense to me. |
Currently the DiscreteUpdater does not check for terminal states.
If isterminal and the simulator are implemented correctly, if we receive an observation, we should be able to conclude that we were not in a terminal state.
The text was updated successfully, but these errors were encountered: