Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Alg4dm book #334

Open
zsunberg opened this issue Feb 2, 2021 · 3 comments
Open

Compatibility with Alg4dm book #334

zsunberg opened this issue Feb 2, 2021 · 3 comments
Labels
Contribution Opportunity This would be something that would be very useful to the community and a good modular addition. major project

Comments

@zsunberg
Copy link
Member

zsunberg commented Feb 2, 2021

I have been noticing that many of my students are translating between the MDP struct in algorithmsbook.com and POMDPs.jl. We should automate this. I think we should make a new package called AlgorithmsBook.jl or similar that provides a convert(AlgorithmsBook.MDP, ::POMDPs.MDP) and vice versa.

@mykelk @tawheeler any thoughts about this? Do you have a repo of code that was used to test the algorithms in the book? That might be useful for developing this package.

@mykelk
Copy link
Member

mykelk commented Feb 2, 2021

Great idea! We haven't made the code available in a repo yet; we've been so focused on getting the book content in shape. In addition to @tawheeler , I think @mossr might have some thoughts.

@tawheeler
Copy link
Contributor

tawheeler commented Feb 3, 2021

Oh interesting. The MDP / POMDP representation in the book is decidedly less efficient than what one typically wants to use "for real" with POMDPs.jl. We could certainly provide a translation though. For example, we don't template on state / action types, and sometimes just leave some fields as "nothing" when they aren't used.

struct MDP
    γ  # discount factor
    𝒮  # state space
    𝒜  # action space
    T  # transition function
    R  # reward function
    TR # sample transition and reward
end

It should be pretty straightforward to support the translation you suggest.

@mossr
Copy link
Member

mossr commented Feb 3, 2021

I'm all for this! There's talk about turning alg4dm into its own Julia package, so this would be useful to do alongside that work.

@zsunberg zsunberg added the Contribution Opportunity This would be something that would be very useful to the community and a good modular addition. label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Opportunity This would be something that would be very useful to the community and a good modular addition. major project
Projects
Development

No branches or pull requests

4 participants