-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should load(::Stream, ...)
methods skip magic bytes?
#163
Comments
I can't remember why it was done this way. I think I've encountered formats where it makes more sense to keep the magic bytes in the stream. So I'm fine with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the README, the example for loading from a stream is:
This works if the user calls
load("somefile.png")
, which will end up calling theload(::File, ...)
method, which handles skipping the magic bytes before callingload(::Stream)
. What I'm not super clear on is how this is intended to be used directly. e.g. I couldn't just do:In ImageMagick.jl it looks like
load
is called on the IO stream directly without skipping the magic(k) bytes.So if it seems like the way ImageMagick does it (leaving the stream at the very beginning of the file when calling
load(::Stream)
) I can put in a documentation PR that clarifies that.The text was updated successfully, but these errors were encountered: