Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow column unioning in Tables.columns #346

Open
bkamins opened this issue Sep 25, 2023 · 3 comments
Open

Allow column unioning in Tables.columns #346

bkamins opened this issue Sep 25, 2023 · 3 comments

Comments

@bkamins
Copy link
Member

bkamins commented Sep 25, 2023

Following the discussion in JuliaData/DataFrames.jl#3372 (comment) It would make sense to add cols kwarg to Tables.columns.

Let us discuss here if it would make sense, because maybe it is better to have a column-oriented equivalent of DictRowTable as a separate object.

CC @nalimilan @quinnj

@bkamins
Copy link
Member Author

bkamins commented Oct 1, 2023

@nalimilan - I have realized that we have Tables.dictcolumntable to accompany Tables.dictrowtable so this issue can be closed. I will update DataFrames.jl accordingly.

@nalimilan
Copy link
Member

Good. It would still make sense to allow opting into a stricter behavior than the default (which I find dangerous) using cols=:setequal or cols=:orderequal. But this is lower priority.

@bkamins
Copy link
Member Author

bkamins commented Oct 5, 2023

Yes - You mean something like Tables.columns(table, cols=:orderequal)? @quinnj - is it clear what we have in mind here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants