Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port useful ERFA functions #2

Open
helgee opened this issue Mar 19, 2018 · 3 comments
Open

Port useful ERFA functions #2

helgee opened this issue Mar 19, 2018 · 3 comments

Comments

@helgee
Copy link
Member

helgee commented Mar 19, 2018 •
edited
Loading

A

B

  • bi00 -> EarthAttitude
  • bp00 -> EarthAttitude
  • bp06 -> EarthAttitude
  • bpn2xy -> EarthAttitude

C

D

E

F

G

H

I

J

L

N

O

P

R

S

T

U

X

Z

  • zp -> unneeded
  • zpv -> unneeded
  • zr -> unneeded
@helgee
Copy link
Member Author

helgee commented Mar 16, 2020

Hey @matzipan, I have pruned the list and indicated in which submodule each function should go. If you want to have a shot at it 😉

@matzipan
Copy link
Contributor

So I've been looking at a2af, and I see there's already rad2dms in Util.jl. Should I create a duplicate implementation? Should I change the return to also include a fraction variable?

@helgee
Copy link
Member Author

helgee commented Mar 20, 2020

Maybe start with duplicates to get your bearings and then we can see how to merge them together. In the end, most things in the library are still in flux right now.

@matzipan matzipan mentioned this issue Mar 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matzipan @helgee