-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to TypeScript #35
Labels
area: tooling
Managing the repository's maintenance
status: accepting prs
Please, send a pull request to resolve this!
Comments
JoshuaKGoldberg
added
status: accepting prs
Please, send a pull request to resolve this!
area: tooling
Managing the repository's maintenance
labels
Sep 13, 2023
This was referenced Sep 13, 2023
Marking as blocked on #39. Types are a bit wonky going back to this very old version of ESLint. |
JoshuaKGoldberg
added
status: blocked
Waiting for something else to be resolved
and removed
status: accepting prs
Please, send a pull request to resolve this!
labels
Sep 20, 2023
JoshuaKGoldberg
added
status: accepting prs
Please, send a pull request to resolve this!
and removed
status: blocked
Waiting for something else to be resolved
labels
Oct 17, 2023
This was referenced Oct 17, 2023
JoshuaKGoldberg
added a commit
that referenced
this issue
Nov 8, 2023
Work in progress: - [x] `npm run tsc` passes - [x] `npm run test` passes (except for #60) - [x] Filed docs issue on `jsonc-eslint-parser` to document how to work effectively with ESTree: ota-meshi/jsonc-eslint-parser#184 Fixes #35. Converts source files to TypeScript. In doing so, switches the test library from Mocha to Vitest so that no transpiling is needed for tests. ~Will wait for feedback on ota-meshi/eslint-plugin-jsonc#269 before taking that PR's strategy in here.~ ✅ Brings in ota-meshi/eslint-plugin-jsonc#271 `RuleListener` type as well. ~Marking as blocked on #60. I'd like that to be resolved before making any changes that happen to also change tests around.~ ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: tooling
Managing the repository's maintenance
status: accepting prs
Please, send a pull request to resolve this!
Confirmed with @zetlen this won't interfere with anything. Yay, TypeScript! 🙌
The text was updated successfully, but these errors were encountered: