-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currency conversion is not working and is wrong in production #2418
Comments
Needs to be investigated but I suspect this to be Coingecko limitation for Arbitrum |
Looking into this now, it looks like on production it's calling coingecko to get a price like this:
Correct me if i'm wrong, but on production it should be using arbitrum one as the asset platform, so using:
The contract address is from Arbitrum, so when it's called using xdai the contract address is wrong and everything is coming back as 0 value. @rdig if this sounds right, i'll work on correcting the asset platform in these urls |
If that is the case, then that does seem like a straight forward solution :) perhaps it should be an environment variable. |
I think I've got it working using the environment variables that we currently have (network_id) and updating the asset_platform map that we use in the coingecko config to handle all the possible network_ids that we currently support. I'll check with the other devs to see what they think. |
…n-wrong-in-production Fix: Use correct asset platform when calling CoinGecko
Steps to reproduce
Expected behaviour
Actual behaviour
The text was updated successfully, but these errors were encountered: