-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically load textures with higher resolution than the screen #149
Labels
Comments
OK, I'd like to help with this one |
ghost
self-assigned this
Jan 20, 2018
@JohnSundell, what do you think? In the occasion we have @2x screen and only @1x and @3x assets, which should have a higher priority? |
@Loyolny I think in that scenario it makes more sense to load the @3x asset, since downscaling usually provides better image quality than upscaling. |
And awesome that you are working on this 😄 |
ghost
mentioned this issue
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, we only automatically fall back to textures with a lower resolution than the screen that the game is running on (for example, if the game is running on an iPhone X and there's no
@3x
asset, then the@2x
or@1x
version will be automatically loaded).We should do the same thing for falling back to a higher resolution as well, that is if the screen is an
@1x
screen but there's only an@2x
asset, that asset should be loaded.Texture loading takes place in
TextureManager
andBundleTextureImageLoader
.The text was updated successfully, but these errors were encountered: