Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] requestFullScreen causes keys to stick #1074

Open
nemosmithasf opened this issue Sep 10, 2023 · 2 comments
Open

[BUG] requestFullScreen causes keys to stick #1074

nemosmithasf opened this issue Sep 10, 2023 · 2 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@nemosmithasf
Copy link

Describe the bug
When the hotkey is used to trigger fullscreen, all subsequent keypresses triggers the hotkey- even keys not assigned.

To Reproduce
Steps to reproduce the behavior:

  1. Add document.documentElement.requestFullscreen to the callback along with any console log
  2. On a browser, activate fullscreen via the hotkey
  3. Now press any key (even if its not assigned to the hotkey), notice how it's triggering the hotkey

Please try and add a codesandbox or stackblitz to reproduce the bug:
<-- Link to reproducable -->
(You need to open the preview code in the pop-out for fullscreen to work)

Additional context
Disabling "keydown" and only listening on "keyup" fixes the issue

@JohannesKlauss JohannesKlauss added the bug Something isn't working label Nov 21, 2023
@JohannesKlauss
Copy link
Owner

Possible duplicate of #1074

@JohannesKlauss JohannesKlauss added the duplicate This issue or pull request already exists label Nov 21, 2023
@farkmarnum
Copy link

Possible duplicate of #1074

Did you mean to reference a different issue? That's this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants