Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin fails to work when secrets contain two '%' symbols #28

Open
Albibek opened this issue Apr 9, 2020 · 1 comment
Open

Plugin fails to work when secrets contain two '%' symbols #28

Albibek opened this issue Apr 9, 2020 · 1 comment

Comments

@Albibek
Copy link

Albibek commented Apr 9, 2020

Hi.

Found a very rare case with password eventually containing two percent symbols, separated by other symbols. If such password is passed via environment variable, plugin puts the parameter value instead of secret.

Version: TeamCity Enterprise 2019.2.2 (build 71923)

Steps to reproduce

  • Create vault secret like {"password": "asdf%1234%zxcv"}
  • Pass the secret over the enviromnent vriable parameter, i.e create the env variable with value %vault:some/path!/password%
  • Variable will have it's original value %vault:some/path!/password% instead of password. This only happens with environment variable.
  • If existing parameter name is used between % symbols (example: { "password": "qwer%teamcity.vault.supported%zxcv" }, the enviromnent variable is templated with this parameter. This happens with both - variable and parameter used "as is".
@ASethi93
Copy link

Hi Albibek , can you helf with this issue : #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants