-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Import-button creates a probably unnecessary huge DOM element #8167
Comments
pmario
changed the title
[But] Import-button creates a huge and probably unnecessary DOM element
[Bug] Import-button creates a huge and probably unnecessary DOM element
Apr 25, 2024
pmario
changed the title
[Bug] Import-button creates a huge and probably unnecessary DOM element
[Bug] Import-button creates a probably unnecessary huge DOM element
Apr 25, 2024
Hi @pmario the approach TW uses for styling file inputs was standard stuff in 2013. I found a few references to it, but not sure which one I used back then: https://l33tsource.com/blog/2013/07/21/Fancy-File-Upload-Buttons/ There may well be better options now that we don't need to worry about Internet Explorer etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While messing with the transclusion detection I did find this one.
The cause is the import-button font-size is 999px, which was introduced 10 years ago. See: 7816c1d
@Jermolene Can you remember why it was set that way. If I remove that value from the stylesheet, the DOM seems to be fixed
See rigth sidebar -> tools -- I'm using the Edge browser to see the DOM levels.
The text was updated successfully, but these errors were encountered: