-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Dark Jackett Theme #6373
Comments
Well, judging from the hearts in your original post, it looks like there is at least one user interested ;-) If you raise a PR I will certainly merge it. |
Cool. I will indeed wait to see if it's something people want. If so I'll continue it and then make a PR for review. |
This does look awesome! Thank you! Is it coming anytime soon? |
Haven't really gotten much feedback that people want it. Ill continue to work on it more soon though. |
your first post has increased its hearts count to 14 ;-) |
I have done two versions. This is second dark theme. I will have to look into how to make a theme switch. Im not fluent in C#. Only PHP, Laravel, Go, Vue and JS. I would say make default dark since it easier. But choice is good. |
The 15 hearts from you original post is basically people telling you to go for it! :) |
Both of your dark themes look great! I don't see why we can't incorporate both, and let users choose & switch as they please. Great work! I really can't wait to use it. I'm never going back to light mode :) |
15 hearts out of 1000's of users is not much bud. But again I can do the themes but making some kind of theme manager I need to talk to @garfield69 or someone that does C# and know core of Jackett |
@HDVinnie Don't worry. Not many users visit this site anyways. This is a case of you build it, and people will use it. It's just that the theme selection drop-box needs to be clearly visible on Jackett's |
@HDVinnie I can help with the theme manager part. Just open a PR with the css/html changes and I will try put all in place. |
Cool ill make a PR tomorrow or Thursday. |
Sorry I have been extremely busy with UNIT3D. Ill try to make time ASAP. |
No problem! Thanks, @HDVinnie! |
@HDVinnie Following up one more time since I'm personally interested in this particular feature :) |
All right. I have two skins/themes I will be making a PR for this week now that I have downtime. It will only contain the CSS and HTML changes. Someone with C# will have to contribute to the PR for adding theme manager. |
@ngosang My eyes will forever thank you if you're able to help with the theme manager! |
This could be tricky in with the current code base but I will try. @HDVinnie maybe you are interested in the UI/UX part => #8180 (comment) |
Saw the new design over on #8180. Looks great, but I hope you don't get rid of the 'Search' box completely. I don't see it in your design; post-search filtration is crucial. Also, feel free to bounce any UI/UX ideas off me while you're designing the new frontend. |
It will be there, don't worry. :) |
For those interested in a dark theme for Jackett, I recommend using the following Firefox Add-on. It works very well for Jackett's Web UI, as well as for most other websites. @ngosang In your UI redesign, you might want to test how the revamped interface looks with this add-on: https://addons.mozilla.org/en-US/firefox/addon/darkreader/ Pretty awesome look for a non-native dark theme, and it's highly customizable: |
it a firefox addon not part of jackett. read #6373 (comment) |
@garfield69 Would there be any interest in a dark theme for Jackett? Started working on one for myself. Its far from done but wondering if it would be something worth PR'ing.
Thanks,
HDVinnie
The text was updated successfully, but these errors were encountered: