Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Dark Jackett Theme #6373

Open
HDVinnie opened this issue Nov 15, 2019 · 25 comments
Open

[Enhancement] Dark Jackett Theme #6373

HDVinnie opened this issue Nov 15, 2019 · 25 comments
Labels
Enhancement Needs C# PR Welcome! We would welcome a volunteer to prepare a PR to solve this problem! Web UI

Comments

@HDVinnie
Copy link
Contributor

@garfield69 Would there be any interest in a dark theme for Jackett? Started working on one for myself. Its far from done but wondering if it would be something worth PR'ing.

Thanks,

HDVinnie

@HDVinnie
Copy link
Contributor Author

HDVinnie commented Nov 15, 2019

Screen-Shot-2019-11-15-at-2-40-38-PM.png

@garfield69
Copy link
Contributor

Well, judging from the hearts in your original post, it looks like there is at least one user interested ;-)
You could wait to see if you get some more, before implementing.

If you raise a PR I will certainly merge it.

@garfield69 garfield69 changed the title [Question] Dark Jackett Theme [Enhancement] Dark Jackett Theme Nov 15, 2019
@HDVinnie
Copy link
Contributor Author

Cool. I will indeed wait to see if it's something people want. If so I'll continue it and then make a PR for review.

@RoloSoze
Copy link
Collaborator

RoloSoze commented Jan 3, 2020

This does look awesome! Thank you! Is it coming anytime soon?

@HDVinnie
Copy link
Contributor Author

HDVinnie commented Jan 4, 2020

Haven't really gotten much feedback that people want it. Ill continue to work on it more soon though.

@garfield69
Copy link
Contributor

your first post has increased its hearts count to 14 ;-)

@HDVinnie
Copy link
Contributor Author

HDVinnie commented Jan 4, 2020

I have done two versions. This is second dark theme.

https://streamable.com/gq4a9

I will have to look into how to make a theme switch. Im not fluent in C#. Only PHP, Laravel, Go, Vue and JS.

I would say make default dark since it easier. But choice is good.

@RoloSoze
Copy link
Collaborator

RoloSoze commented Jan 4, 2020

Haven't really gotten much feedback that people want it. Ill continue to work on it more soon though.

The 15 hearts from you original post is basically people telling you to go for it! :)

@RoloSoze
Copy link
Collaborator

RoloSoze commented Jan 4, 2020

I have done two versions. This is second dark theme.

https://streamable.com/gq4a9

I will have to look into how to make a theme switch. Im not fluent in C#. Only PHP, Laravel, Go, Vue and JS.

Both of your dark themes look great! I don't see why we can't incorporate both, and let users choose & switch as they please.

Great work! I really can't wait to use it. I'm never going back to light mode :)

@HDVinnie
Copy link
Contributor Author

HDVinnie commented Jan 5, 2020

Haven't really gotten much feedback that people want it. Ill continue to work on it more soon though.

The 15 hearts from you original post is basically people telling you to go for it! :)

15 hearts out of 1000's of users is not much bud. But again I can do the themes but making some kind of theme manager I need to talk to @garfield69 or someone that does C# and know core of Jackett

@RoloSoze
Copy link
Collaborator

RoloSoze commented Jan 5, 2020

@HDVinnie Don't worry. Not many users visit this site anyways. This is a case of you build it, and people will use it. It's just that the theme selection drop-box needs to be clearly visible on Jackett's
Dashboard (perhaps between the Jackett logo & the API Key?) for people to try it out.

@ngosang
Copy link
Member

ngosang commented Jan 11, 2020

@HDVinnie I can help with the theme manager part. Just open a PR with the css/html changes and I will try put all in place.

@ngosang ngosang added PR Welcome! We would welcome a volunteer to prepare a PR to solve this problem! Needs C# Web UI labels Jan 14, 2020
@HDVinnie
Copy link
Contributor Author

Cool ill make a PR tomorrow or Thursday.

@RoloSoze
Copy link
Collaborator

RoloSoze commented Mar 8, 2020

@HDVinnie @ngosang Any progress on the dark theme? I still think your dark theme concepts look awesome, @HDVinnie! Both of them.

@HDVinnie
Copy link
Contributor Author

HDVinnie commented Mar 8, 2020

Sorry I have been extremely busy with UNIT3D. Ill try to make time ASAP.

@RoloSoze
Copy link
Collaborator

RoloSoze commented Mar 9, 2020

Sorry I have been extremely busy with UNIT3D. Ill try to make time ASAP.

No problem! Thanks, @HDVinnie!

@RoloSoze
Copy link
Collaborator

@HDVinnie Following up one more time since I'm personally interested in this particular feature :)

@HDVinnie
Copy link
Contributor Author

All right. I have two skins/themes I will be making a PR for this week now that I have downtime. It will only contain the CSS and HTML changes. Someone with C# will have to contribute to the PR for adding theme manager.

@RoloSoze
Copy link
Collaborator

@ngosang My eyes will forever thank you if you're able to help with the theme manager!

@ngosang
Copy link
Member

ngosang commented Apr 14, 2020

This could be tricky in with the current code base but I will try. @HDVinnie maybe you are interested in the UI/UX part => #8180 (comment)

@RoloSoze
Copy link
Collaborator

This could be tricky in with the current code base but I will try. @HDVinnie maybe you are interested in the UI/UX part => #8180 (comment)

Saw the new design over on #8180. Looks great, but I hope you don't get rid of the 'Search' box completely. I don't see it in your design; post-search filtration is crucial. Also, feel free to bounce any UI/UX ideas off me while you're designing the new frontend.

@ngosang
Copy link
Member

ngosang commented Apr 14, 2020

I hope you don't get rid of the 'Search' box completely.

It will be there, don't worry. :)

@RoloSoze
Copy link
Collaborator

RoloSoze commented May 7, 2020

For those interested in a dark theme for Jackett, I recommend using the following Firefox Add-on. It works very well for Jackett's Web UI, as well as for most other websites. @ngosang In your UI redesign, you might want to test how the revamped interface looks with this add-on:

https://addons.mozilla.org/en-US/firefox/addon/darkreader/

Pretty awesome look for a non-native dark theme, and it's highly customizable:

image

@dreulavelle
Copy link

Whatever happened to this look, it looked way better lol

image

@garfield69
Copy link
Contributor

it a firefox addon not part of jackett. read #6373 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Needs C# PR Welcome! We would welcome a volunteer to prepare a PR to solve this problem! Web UI
Projects
None yet
Development

No branches or pull requests

5 participants