Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[req]: make login selectorinputs optional #14825

Open
1 task done
ilike2burnthing opened this issue Nov 6, 2023 · 1 comment
Open
1 task done

[req]: make login selectorinputs optional #14825

ilike2burnthing opened this issue Nov 6, 2023 · 1 comment
Labels
Core Enhancement Needs C# PR Welcome! We would welcome a volunteer to prepare a PR to solve this problem!

Comments

@ilike2burnthing
Copy link
Contributor

Is there already a request for your feature?

  • I have checked older issues, open and closed

Is your feature request related to a problem? Please describe.

Tapochek presents a captcha if incorrect credentials have been used more than once from a specific IP. As well as the captcha, there are now also hidden inputs. The login block below works if using the flagged IP address, but fails if using a proxy/VPN, as the selectors cannot be found.

login:
  path: login.php
  method: form
  form: form[action$="/login.php"]
  captcha:
    type: image
    selector: img[src^="profile.php?mode=confirm&id="]
    input: cfmcd
  inputs:
    login_username: "{{ .Config.username }}"
    login_password: "{{ .Config.password }}"
    autologin: on
    redirect: /
  selectorinputs:
    cookie_test:
      selector: input[name="cookie_test"]
      attribute: value
    confirm_id:
      selector: input[name="confirm_id"]
      attribute: value
    sid:
      selector: input[name="sid"]:not(input[id="dl-sid"])
      attribute: value
  error:
    - selector: h4:contains("Вы ввели")
  test:
    path: index.php
    selector: a[href="./login.php?logout=1"]

If wanting to test this, I recommend using a proxy/VPN when entering the wrong credentials, as no matter how many times I enter the correct credentials I'm still getting the captcha on each successive login attempt.

Describe the solution you'd like

login selectorinputs be optional

Describe alternatives you've considered

login selectorinputs support optional: true

@ilike2burnthing ilike2burnthing added Enhancement PR Welcome! We would welcome a volunteer to prepare a PR to solve this problem! Core Needs C# labels Nov 6, 2023
@garfield69
Copy link
Contributor

I vote for option 2, allowing for optional: true, which falls in line with other selector usage, such as in the search block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Enhancement Needs C# PR Welcome! We would welcome a volunteer to prepare a PR to solve this problem!
Projects
None yet
Development

No branches or pull requests

2 participants