Cleanup definition constraint generation #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSAbrahams
added
the
bug: check
JSAbrahams
force-pushed
the
fix-type-alias
branch
from
751d9be
to
d1399e4
Compare
JSAbrahams
changed the title
JSAbrahams
added
code quality: general
Codecov Report
@@ Coverage Diff @@
## develop #340 +/- ##
===========================================
+ Coverage 86.48% 86.51% +0.02%
===========================================
Files 109 109
Lines 11637 11625 -12
===========================================
- Hits 10064 10057 -7
+ Misses 1573 1568 -5 |
JSAbrahams
added a commit
that referenced
this pull request
Jun 7, 2022
* Make `TrueName` default mutability true * Simplify definition generation logic
JSAbrahams
added a commit
that referenced
this pull request
Jun 7, 2022
* Make `TrueName` default mutability true * Simplify definition generation logic
JSAbrahams
added a commit
that referenced
this pull request
Jun 8, 2022
* Make `TrueName` default mutability true * Simplify definition generation logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Started as a fix for #329 , turned into just general code cleanup.
TrueNamemutable by default, which is the behaviour we expect.