Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra "Where Used" menu item? #13114

Closed
jerryg2003 opened this issue May 23, 2024 · 3 comments · Fixed by #13152
Closed

Extra "Where Used" menu item? #13114

jerryg2003 opened this issue May 23, 2024 · 3 comments · Fixed by #13152

Comments

@jerryg2003
Copy link
Contributor

Version 5.7.2, Windows 11

This command selection is as expected:

Tools==>Where Used
but also have:

Tools==>LogixNG==>Where Used
...with a slightly different popup window display, missing the help line.

Is this intended?

@danielb987
Copy link
Contributor

danielb987 commented May 31, 2024

The reason for two different "Where Used" is that the first is generic for JMRI but it only shows the LogixNG action/expression that uses a bean.

The second "Where Used" is specific to LogixNG and have the benefit that it shows more detailed information about where a bean is used. The LogixNG, the ConditonalNG, and so on. It makes it much easier to find the action/expression that actually uses the bean.

The reason the second "Where Used" doesn't have help is that I'm not good at writing documentation. So I focus on making the code work. Then, if someone wants, it's easy to add the documentation too.

@dsand47
Copy link
Contributor

dsand47 commented Jun 1, 2024 via email

@dsand47 dsand47 linked a pull request Jun 1, 2024 that will close this issue
@jerryg2003
Copy link
Contributor Author

So Tools==>LoxigNG==>Where Used provides different capability from Tools==>Where Used. According to @danielb987, it provides more details about LNGs so maybe the menu item should have a different name, e.g.

Tools==>LogixNG==>Where Used (Detail)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants