Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple arguments have been removed from _generate_descale_mask in kagefunc #68

Open
MewX opened this issue Aug 7, 2021 · 2 comments

Comments

@MewX
Copy link

MewX commented Aug 7, 2021

In descaling section, the tutorial mentioned a way to use internal functions to generate credits masks:

descaled = kgf.inverse_scale(src, height=874, kernel='bicubic', b=0, c=1/2)
descaled_mask = kgf._generate_descale_mask(vsutil.get_y(core.resize.Spline36(src, descaled.width, descaled.height)), vsutil.get_y(descaled), kernel='bicubic', b=0, c=1/2)

However, the function has been reworked in: Irrational-Encoding-Wizardry/kagefunc@5c7cd67

@LightArrowsEXE
Copy link
Member

I believe I rewrote that part in #56, but that was closed because I wasn't happy with my write-ups. Maybe it's time I get around to writing one I am happy with.

@MewX
Copy link
Author

MewX commented Aug 8, 2021

Ah, great thanks! Looking forward to it :D

Attaching some snippets that I ended up using to compare source (8 bit), mask and filtered if that helps:

from lvsfunc import kernels, scale
... ...

src8 = core.text.Text(src8, "Source")
debanded = core.text.Text(debanded, "Filtered")

descaled_mask = scale.descale(dirtylines, height=855, kernel=kernels.Bicubic(), show_mask=True)
descaled_mask = descaled_mask.resize.Point(format=debanded.format)
descaled_mask = core.text.Text(descaled_mask, "Mask")
comparison = core.std.Interleave([src8, descaled_mask, debanded])
comparison.set_output()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants