Generate screenshots for parts with any code within them [solved in #209] #208
Replies: 2 comments 3 replies
-
|
You're 100% right this would be useful. I've actually wanted to do this, but haven't taken the time to dive in figure out how to make it work. Sounds like you already have an idea with the canvas. I made issue #111 because CascadeStudio had an experimental branch where this same feature was implemented, so looking at that code may help (at least that was what I was planning on doing, but happy for you do it whichever way you think best). In regards to when to take the screen shot, I agree that taking one every time it generates seems a little problematic, how about instead we add a button in this section |
Beta Was this translation helpful? Give feedback.
-
|
The button in the top bar is a great solution! I will look into the screenshot utility code and try a few things this evening, and I've created a page in Figma to sketch ideas, will let you know when they're ready to review. |
Beta Was this translation helpful? Give feedback.
-
|
Sounds good @franknoirot 😁 When it comes to storing the images, the image is sent directly to cloundinary |
Beta Was this translation helpful? Give feedback.
-
|
Alright @Irev-Dev I've made some progress. Here are my Figma sketches , you can give your thoughts and feedback using the comment tool (tapping the "C" key) and tagging me if you like. Some notes I realized while mocking it up:
I've made some headway on wiring up the logic over in my fork, got an image to be collected out of CascadeStudio (you were right, it was very straightforward to adapt Zalo's code), and am just about ready to put together the Cloudinary logic. I should have time tomorrow evening to work more. |
Beta Was this translation helpful? Give feedback.
-
|
The designs look really great 😄, I left one comment in figma, but nothing I have to say is actually on the UI. I'm happy with the more verbose wording about setting part image because I think that's going to be the main usecase plus I think we should be encouraging it. Capturing a screenshot automatically on first save is a good idea, I think it's better to have something at least (but not urgent if that's difficult to implement or can be done in a later PR). Something I need to fix is one weird quirk of the current setup is that a user's parts don't show up on the home page until they've set an image, this was a way of shortcutting not having a publish setting on parts (because I was getting a few junk parts where people whole just fork something just to test it out and do nothing else with it and then that would show up on the home page), but that's something I should prioritise if you're working on this. There's very little done in the way of browsing other part atm, I don't even have basic search atm. I can see you've got a PR up, that's great. It's getting a bit late here in Aus, I should be able to look at it in the morning. |
Beta Was this translation helpful? Give feedback.
-
Hi there! Love this project, and would love to help however I can.
I think that parts could benefit from having screenshots generated of them, perhaps by hooking into the Save functionality.
Codepen generates screenshots of pens for use on mobile and metadata generation. They are a rails app and do their work server side.
Since all CadHub parts are 3d viewports and therefore always just a
<canvas>element, could it be saved from the client side directly by listening for a successful model generation, then saving the canvas as the thumbnail, saving the image to the database and replacing the old one?One issue with the above is that it then relies on the user being in the right camera position when they save if they want the thumbnail to look good.
Beta Was this translation helpful? Give feedback.
All reactions