Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch naming not working for types other than feature #70

Closed
lluisoh opened this issue Mar 20, 2024 · 2 comments · Fixed by #94
Closed

Branch naming not working for types other than feature #70

lluisoh opened this issue Mar 20, 2024 · 2 comments · Fixed by #94
Assignees
Labels
kind/feature Changes implying a new feature for the user

Comments

@lluisoh
Copy link

lluisoh commented Mar 20, 2024

Detailed description

When we try to create a PR or branch and the cli prompts us to select the type of branch, if we select the type other, instead of prompting to select among the other types (bugfix, dependency, deprecation, etc), it jumps straight to branch naming and ends up using "other" as a prefix.

Check this video:

Screen.Recording.2024-03-20.at.11.56.47.mov

Expected behaviour

When we select other in the type of branch prompt, it should offer other branch types allow the user to select among them. Like the following screenshot from a previous version of sherpa-cli:

Screenshot 2024-03-20 at 12 16 11

@lluisoh lluisoh added the kind/bug Something isn't working label Mar 20, 2024
@hielfx
Copy link
Member

hielfx commented Mar 25, 2024

Hi! Thanks for reporting this issue. We will review this behavior and address it.

@jorgegarciarey
Copy link
Contributor

@lluisoh , we're going to release a new version in a few days with this fix and some additional features.

@hielfx hielfx added kind/feature Changes implying a new feature for the user and removed kind/bug Something isn't working labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Changes implying a new feature for the user
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants