Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull Request ID as Issue ID #17

Closed
hielfx opened this issue Sep 27, 2023 · 0 comments · Fixed by #88
Closed

Pull Request ID as Issue ID #17

hielfx opened this issue Sep 27, 2023 · 0 comments · Fixed by #88
Assignees
@hielfx
Labels
kind/bug Something isn't working

Comments

@hielfx
Copy link
Member

hielfx commented Sep 27, 2023

Detailed description

If you pass a Pull Request ID as the --issue flag, it will create another Pull Request.

We should check if the given ID is from a Pull Request or an Issue and force the Issue one.

Expected behaviour

When given a pull request ID, the CLI should tell the user and stop the execution.
@hielfx hielfx added the kind/bug Something isn't working label Sep 27, 2023
@hielfx hielfx self-assigned this Sep 27, 2023
@hielfx hielfx removed their assignment Feb 9, 2024
@hielfx hielfx mentioned this issue May 28, 2024
Merged
hielfx added a commit that referenced this issue Jun 5, 2024
@hielfx
Merge branch 'main' into bugfix/GH-17-pull-request-id-as-issue-id
d5a2daf
@hielfx hielfx closed this as completed in #88 Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hielfx hielfx

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pull Request ID as Issue ID InditexTech/gh-sherpa
1 participant
@hielfx