-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checks that values satisfy requirements of the VR #136
Comments
See also pydicom/pydicom#1414 |
We should avoid the global configuration as much as possible. My preferred approach would be to add a parameter to the constructor of |
A note here that pydicom 2.3.0 has a lot of new functionality to help us here, we just need to figure out how to best make use of it |
This has been discussed before (e.g. here) but we should have an issue to track it.
Pydicom is very loose in what it allows you to set as an attribute's value, even when you have the global configuration option
pydicom.config.enforce_valid_values
set toTrue
. We have previously encountered and resolved this narrowly for decimal strings (DS) #57 #65, but the issue is broader. Checks for the other VRs are largely absent from pydicom, but many VRs have limits on length of the string, list of allowable characters, capitalisation, etc (see standard). The result is many one-off checks being including to check user-supplied values in highdicom, as well as probably many missed checks that could allow files with invalid values to be produced. We should tackle this in a more unified way to reduce redundancy and probability of invalid values slipping through the net.My feeling is that as far as possible we should add this functionality to pydicom and then integrate into highdicom.
The text was updated successfully, but these errors were encountered: