Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the Escape key for cancelling changes #75

Open
asoltesz opened this issue Feb 16, 2021 · 2 comments
Open

Support the Escape key for cancelling changes #75

asoltesz opened this issue Feb 16, 2021 · 2 comments

Comments

@asoltesz
Copy link

It would be nice to have the editing dialogs closed on pressing the Escape key (as usually expected with dialogs)

@Ilogeek
Copy link
Owner

Ilogeek commented Feb 17, 2021

Hi @asoltesz

I'm glad my plugin gives you so much ideas and we can definitely add some to improve the plugin!
Don't hesitate to submit your PR if you already have implemented some of them and I'll merge your PR into the project as soon as possible.
I'll take a look for this specific feature, escape key press is something interesting to add to the plugin

If you find the plugin helpful, take a minute to star it on Github and rate it 5 stars on http://www.redmine.org/plugins/redmine_issue_dynamic_edit 👍

Have a good day too

@asoltesz
Copy link
Author

@Ilogeek Yes, dynamic_edit is a great productivity booster makes one enthusiastic. (thanks for the plugin BTW)

I would love to contribute, although I have nonexistent Ruby/Rails skills and limited in Javascript. I will take a look and see if I can implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants