-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove installer scripts in favor of popular or upstream install methods #47
Comments
turns out the sops download still really benefits from having a script to get the current tag, since that value is also in the artifact filenames. Plus, the format for different platforms is not exactly consistent. In #58 I have edited that file to be a little more targeted and added some features. As for sopstoolinstall and install.sh, I do kind of agree - and in that PR mentioned above, moved those lower in the README. I'm ok with potentially dropping those though. IMO our releases are pretty straightforward to acquire. The install script is just nice because it does automatically solve a couple things like sha256 validation and platform selection. |
Current Behavior
Currently, we recommend installing
sopstool
via the install.sh script. This installs sops first before installing sopstool. I believe we should instead ask the user to installsops
themselves. Other popular wrapper tools like terragrunt or saml2aws do this to simplify management of their tool. I propose we:While the scripts themselves aren't a ton of maintenance, it'll just be less the maintain. I'm stuck between hard coding 3.7.2 into Travis or the Dockerfile, or just saying "install
sops
" and worrying about compatibility ourselves though.The text was updated successfully, but these errors were encountered: