Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.2-14] Allowing Other_1, Other_2, and some other small fixes #22

Open
3 of 4 tasks
retostauffer opened this issue May 15, 2024 · 0 comments
Open
3 of 4 tasks
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@retostauffer
Copy link
Collaborator

retostauffer commented May 15, 2024

@gabroko

I have been playing around this morning on my development branch fixing/implementing what you've told me the other day. Will open an issue for this to keep track. These changes will enter 0.2-14 (not yet in the main head branch) but can technically be tested by installing the development branch (tough, might undergo additional changes)

  • install_github("IEA-EBC-Annex86/annex", ref = "devel")

Broken documentation links

  • Thanks for pointing this out, configfile.html does no longer exist, should point to config.html. I've adjusted the vignettes, will be fixed when 0.2.14 is released.

The "Other" variables

You asked if we could allow the user to specify multiple Other variables for the same study/home/room (up to 0.2-13 only one is allowed; see also #20).

  • The XLSX template Definitions sheet now contains a new column "Allowed" which can be 1, 10, or 100.
    • If 1: Can only occur once (e.g., as "Other").
    • If 10: Can occur up to 11 times (as "Other", "Other_0", "Other_1", ..., "Other_9".
    • If 100: Can occur up to 101 times (same system as above).
  • Implemented the logic and - for testing - allowing for 10 allowed occurrences for PMOther and T, as well as up to 100 allowed occurrences for Other (testing!).

Update: Old gist (simulated test) no longer works as the variables now must contain underscores (not implemented when writing that small test).

Information/units for "Other" variables

@retostauffer retostauffer self-assigned this May 15, 2024
@retostauffer retostauffer added the enhancement New feature or request label May 15, 2024
@retostauffer retostauffer added this to the Version 0.2 milestone May 15, 2024
@retostauffer retostauffer changed the title [0.2-14] Allowing Other1, Other2, and some other small fixes [0.2-14] Allowing Other_1, Other_2, and some other small fixes May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant