Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change META Home "Method of vent. rate determination" to dropdown #16

Open
gabroko opened this issue Oct 27, 2023 · 1 comment
Open

Comments

@gabroko
Copy link
Contributor

gabroko commented Oct 27, 2023

Allow entries in META Home's "Method of vent. rate determination" only to be from the list in definition (same as in META Room).
Update "validate" function to check those META Home entries

@retostauffer
Copy link
Collaborator

@gabroko Thanks for opening the issue.

I (only on my local copy) added the same "validate" rules to META-Home as the one we use in META-Room.

Status

  • In both cases, this is a non-required (non-mandatory) field, the user can leave it empty.
  • I also do not validate (check) what's in there in our R package.

Options

I see two options:

  1. We leave it as is (XLSX validates, R does not care)
  2. We could implement a check in R (annex_validate()) to force the user to either
    • Leave it empty (as it is a non-mandatory field)
    • If not empty, it must be one of the values in the definition table (ensure the user does not overrule the XLSX validation)

What should we go for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants