Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy attention based decoder #153

Open
AtmaHou opened this issue Jul 12, 2018 · 10 comments
Open

Copy attention based decoder #153

AtmaHou opened this issue Jul 12, 2018 · 10 comments

Comments

@AtmaHou
Copy link

AtmaHou commented Jul 12, 2018

You guys really did an excellent work with high scalability. Better than OpenNMT in my opinion :)

Copy mechanism could greatly enhance the performance of Seq2Seq model, would you guys implement a decoder with copy mechanism?

@pskrunner14
Copy link

@AtmaHou we'll see if it can be integrated in the next release. You're welcome to submit a PR. We need all the help we can get.

@AtmaHou
Copy link
Author

AtmaHou commented Sep 1, 2018

Thanks for your reply, it will be in great need.

@pskrunner14 pskrunner14 self-assigned this Sep 2, 2018
@varunAI
Copy link

varunAI commented Sep 19, 2018

Any Update on this?

@pskrunner14
Copy link

@varunAI Yup working on it. Will push to develop as soon as it's done.

@rrkarim
Copy link

rrkarim commented Oct 6, 2018

@pskrunner14 I can work on this if you need some help.

@Diego999
Copy link

Diego999 commented Nov 5, 2018

@pskrunner14 Any news on this ?

@Diego999
Copy link

Diego999 commented Nov 6, 2018

@pskrunner14 is this PR #172 reliable for the copy mechanism ?

@pskrunner14
Copy link

@Diego999 no, I'm facing some issues with dimensions as mentioned and there seems to be a problem with the dynamic dictionary too. I'll get to this asap. Will post any updates on this thread.

@Diego999
Copy link

Diego999 commented Nov 6, 2018

@pskrunner14 Thank you for your quick answer !

@Diego999
Copy link

@pskrunner14 Do you have any news about it ? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants