Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move train hooks from trainer to gan object #272

Open
martyn opened this issue Aug 9, 2020 · 0 comments
Open

Move train hooks from trainer to gan object #272

martyn opened this issue Aug 9, 2020 · 0 comments

Comments

@martyn
Copy link
Contributor

martyn commented Aug 9, 2020

Train hooks should be a base level array on the GAN itself. This is because it has functionality that is unrelated to the trainer, such as augmenting discriminator inputs, changing the latent vector, etc.

1.0 configs should continue to work, so it should be something like:

(pseudo-code)

def gan.train_hooks
  search config.train_hooks or config.trainer.train_hooks
@martyn martyn changed the title Refactor: Move train hooks from trainer to gan object Move train hooks from trainer to gan object Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant