Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

Notifications trigger on Contribution Comment update. #106

Open
ghost opened this issue Jul 10, 2018 · 2 comments
Open

Notifications trigger on Contribution Comment update. #106

ghost opened this issue Jul 10, 2018 · 2 comments
Labels
Bug Something isn't working Help-Wanted Extra attention is needed
Projects
Human-Connection

Comments

@ghost
Copy link

ghost commented Jul 10, 2018

When a user updates a comment with a mention inside it will trigger the notification again.
@ghost ghost created this issue from a note in Human-Connection (To Do) Jul 10, 2018
@ghost
Copy link
Author

ghost commented Jul 14, 2018

I have been able to reproduce this issue once again:

When a user upvotes a comment with a mention inside, all mentioned users get the notification "you've been mentioned" again. I assume this also causes some issues on performance (more votes, more notifications as they double up with each mention and vote).

@ghost ghost added Bug Something isn't working Help-Wanted Extra attention is needed labels Jul 14, 2018
appinteractive added a commit that referenced this issue Jul 15, 2018
@appinteractive
Fixed doubled notification issue
8c7b0cc 
This commit fixed the issue where up-voting or editing an comment leads to sending the mention notification again. See #106
@appinteractive appinteractive mentioned this issue Jul 15, 2018
Merged
@appinteractive
Copy link
Member

@sebako86 please take a look at my pull request on above.

@appinteractive appinteractive moved this from To Do to Done in Human-Connection Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Something isn't working Help-Wanted Extra attention is needed
Projects
Human-Connection
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@appinteractive