Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/Resolve Obsolete Methods before DNN 11 #332

Open
WillStrohl opened this issue Oct 23, 2020 · 2 comments
Open

Remove/Resolve Obsolete Methods before DNN 11 #332

WillStrohl opened this issue Oct 23, 2020 · 2 comments
Labels
Task

Comments

@WillStrohl
Copy link
Member

Describe the bug

There about 9 methods/API calls that will be obsolete in DNN 11. They need to be updated to use the replacement API endpoint and/or development pattern in DNN.

Providers\HccFriendlyUrlProvider.cs(84,32): warning CS0672: Member 'Hotcakes.Commerce.Dnn.Providers.HccFriendlyUrlProvider.FriendlyUrl(DotNetNuke.Entities.Tabs.TabInfo, string, string, DotNetNuke.Entities.Portals.PortalSettings)' overrides obsolete member 'DotNetNuke.Services.Url.FriendlyUrl.FriendlyUrlProvider.FriendlyUrl(DotNetNuke.Entities.Tabs.TabInfo, string, string, DotNetNuke.Entities.Portals.PortalSettings)'. Add the Obsolete attribute to 'Hotcakes.Commerce.Dnn.Providers.HccFriendlyUrlProvider.FriendlyUrl(DotNetNuke.Entities.Tabs.TabInfo, string, string, DotNetNuke.Entities.Portals.PortalSettings)'. [c:\Work\HCC-core\hcc-core\Libraries\Hotcakes.Commerce.Dnn\Hotcakes.Commerce.Dnn.csproj]
  c:\Work\HCC-core\hcc-core\References\Dnn\DotNetNuke.dll: (Location of symbol related to previous warning)
DnnMembershipServices.cs(124,20): warning CS0618: 'DotNetNuke.Common.Globals.NavigateURL(int, string, params string[])' is obsolete: 'Deprecated in Platform 9.4.2. Scheduled removal in v11.0.0.' [c:\Work\HCC-core\hcc-core\Libraries\Hotcakes.Commerce.Dnn\Hotcakes.Commerce.Dnn.csproj]
Mvc\DnnHccUrlResolver.cs(109,24): warning CS0618: 'DotNetNuke.Common.Globals.NavigateURL(string)' is obsolete: 'Deprecated in Platform 9.4.2. Scheduled removal in v11.0.0.' [c:\Work\HCC-core\hcc-core\Libraries\Hotcakes.Commerce.Dnn\Hotcakes.Commerce.Dnn.csproj]
Mvc\DnnHccUrlResolver.cs(113,24): warning CS0618: 'DotNetNuke.Common.Globals.NavigateURL(string)' is obsolete: 'Deprecated in Platform 9.4.2. Scheduled removal in v11.0.0.' [c:\Work\HCC-core\hcc-core\Libraries\Hotcakes.Commerce.Dnn\Hotcakes.Commerce.Dnn.csproj]
Mvc\DnnHccUrlResolver.cs(117,24): warning CS0618: 'DotNetNuke.Common.Globals.NavigateURL(string)' is obsolete: 'Deprecated in Platform 9.4.2. Scheduled removal in v11.0.0.' [c:\Work\HCC-core\hcc-core\Libraries\Hotcakes.Commerce.Dnn\Hotcakes.Commerce.Dnn.csproj]
Mvc\DnnHccUrlResolver.cs(166,31): warning CS0618: 'DotNetNuke.Common.Globals.NavigateURL(int, bool, DotNetNuke.Entities.Portals.PortalSettings, string, string, params string[])' is obsolete: 'Deprecated in Platform 9.4.2. Scheduled removal in v11.0.0.' [c:\Work\HCC-core\hcc-core\Libraries\Hotcakes.Commerce.Dnn\Hotcakes.Commerce.Dnn.csproj]
Providers\HccFriendlyUrlProvider.cs(74,35): warning CS0618: 'DotNetNuke.Entities.Portals.IPortalController.GetCurrentPortalSettings()' is obsolete: 'Deprecated in Platform 9.4.2. Scheduled removal in v11.0.0. Use GetCurrentSettings instead.' [c:\Work\HCC-core\hcc-core\Libraries\Hotcakes.Commerce.Dnn\Hotcakes.Commerce.Dnn.csproj]
Providers\HccFriendlyUrlProvider.cs(75,20): warning CS0618: 'DotNetNuke.Services.Url.FriendlyUrl.FriendlyUrlProvider.FriendlyUrl(DotNetNuke.Entities.Tabs.TabInfo, string, string, DotNetNuke.Entities.Portals.PortalSettings)' is obsolete: 'Deprecated in Platform 9.4.3. Scheduled for removal in v11.0.0. Use the IPortalSettings overload' [c:\Work\HCC-core\hcc-core\Libraries\Hotcakes.Commerce.Dnn\Hotcakes.Commerce.Dnn.csproj]
Providers\HccFriendlyUrlProvider.cs(80,35): warning CS0618: 'DotNetNuke.Entities.Portals.IPortalController.GetCurrentPortalSettings()' is obsolete: 'Deprecated in Platform 9.4.2. Scheduled removal in v11.0.0. Use GetCurrentSettings instead.' [c:\Work\HCC-core\hcc-core\Libraries\Hotcakes.Commerce.Dnn\Hotcakes.Commerce.Dnn.csproj]
Providers\HccFriendlyUrlProvider.cs(81,20): warning CS0618: 'DotNetNuke.Services.Url.FriendlyUrl.FriendlyUrlProvider.FriendlyUrl(DotNetNuke.Entities.Tabs.TabInfo, string, string, DotNetNuke.Entities.Portals.PortalSettings)' is obsolete: 'Deprecated in Platform 9.4.3. Scheduled for removal in v11.0.0. Use the IPortalSettings overload' [c:\Work\HCC-core\hcc-core\Libraries\Hotcakes.Commerce.Dnn\Hotcakes.Commerce.Dnn.csproj]

ProductReviews\ProductReviewsView.ascx.cs(49,43): warning CS0618: 'DotNetNuke.Common.Globals.NavigateURL(int)' is obsolete: 'Deprecated in Platform 9.4.2. Scheduled removal in v11.0.0.' [c:\Work\HCC-core\hcc-core\Website\DesktopModules\Hotcakes\Hotcakes.Modules.csproj]
ProductViewer\ProductViewerView.ascx.cs(62,43): warning CS0618: 'DotNetNuke.Common.Globals.NavigateURL(int)' is obsolete: 'Deprecated in Platform 9.4.2. Scheduled removal in v11.0.0.' [c:\Work\HCC-core\hcc-core\Website\DesktopModules\Hotcakes\Hotcakes.Modules.csproj]
@WillStrohl WillStrohl added this to the 03.06.00 milestone Oct 23, 2020
@WillStrohl WillStrohl modified the milestones: 03.06.00, 03.07.00 Nov 30, 2021
@WillStrohl WillStrohl modified the milestones: 03.07.00, 03.08.00 Oct 24, 2022
@WillStrohl
Copy link
Member Author

There are more now... ;)

@WillStrohl WillStrohl removed this from the 03.08.00 milestone Jul 16, 2023
@WillStrohl
Copy link
Member Author

Cleared the milestone, as we'll need to wait until we're closer to DNN 11 before we can resolve many of these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WillStrohl