Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump ruby/setup-ruby from 1.175.0 to 1.175.1 #599

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 29, 2024

Bumps ruby/setup-ruby from 1.175.0 to 1.175.1.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.175.0 to 1.175.1.
- [Release notes](https://github.com/ruby/setup-ruby/releases)
- [Commits](ruby/setup-ruby@70da3bb...1198b07)

---
updated-dependencies:
- dependency-name: ruby/setup-ruby
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies github_actions Pull requests that update Github_actions code labels Apr 29, 2024
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once someone figures out why CI is very angry 😡

@woodruffw
Copy link
Member

Looks like this might be another variant of "3p PRs don't get access to the CodeCov secret," although I could have sworn Dependabot was special-cased 🤔

@Bo98 any thoughts here? I remember mentioning you knew a fix for this.

@MikeMcQuaid
Copy link
Member

@Bo98 any thoughts here? I remember mentioning you knew a fix for this.

@woodruffw my solutions have been:

  • update the CodeCov integration to a newer/different version that fixes the problem (i.e. go through their docs and make sure we are using the codecov/codecov-action@v4
  • hardcode the CodeCov token so it's usable everywhere (not desirable)
  • more generically: adjust the CI logic so dependabot doesn't try to do things that require tokens

@Bo98
Copy link
Member

Bo98 commented Apr 29, 2024

Currently on holiday so will check on this on Wednesday but yes what we needed to do was rip out the deprecated Ruby gem and replace with codecov-action@v4. It supports Dependabot/3rd-party scenarios.

@woodruffw
Copy link
Member

I'll take a stab at that! Sorry for the ping on your vacation @Bo98, I can handle things from here 🙂

Copy link
Contributor Author

dependabot bot commented on behalf of github May 6, 2024

Superseded by #600.

@dependabot dependabot bot closed this May 6, 2024
@dependabot dependabot bot deleted the dependabot/github_actions/ruby/setup-ruby-1.175.1 branch May 6, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants