Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MachOView needs to support lazy loading for content #433

Open
rickmark opened this issue Jan 14, 2022 · 5 comments
Open

MachOView needs to support lazy loading for content #433

rickmark opened this issue Jan 14, 2022 · 5 comments

Comments

@rickmark
Copy link
Contributor

As we start to parse contents of various regions, it would be helpful to not hold in memory @raw_data but materialize as needed in MachOView.

This can be accomplished by using the new file reference and seek / read to pull in the data lazy

@woodruffw
Copy link
Member

Yeah, that's the idea behind #23. I opened that years ago and never got around to it, partially because the performance gains weren't substantial for Homebrew's use case. But I would happily accept a changeset for that now.

@rickmark
Copy link
Contributor Author

rickmark commented Jan 14, 2022 via email

@woodruffw
Copy link
Member

Yeah, that's the trouble with mmap. We could consider the mmap gem but in general we've tried to keep ruby-macho at zero dependencies because it gets vendored into Homebrew.

@github-actions
Copy link

github-actions bot commented Feb 5, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the Stale label Feb 5, 2022
@woodruffw woodruffw removed the Stale label Feb 6, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants