formulae_detect: actually use origin/master for starting SHA1
#908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here, `origin_ref` points to the temporary merge group branch, so it will be the same as `GITHUB_SHA`.
MikeMcQuaid
reviewed
Apr 14, 2023
| diff_start_sha1 = rev_parse(origin_ref) | ||
| origin_ref = "origin/#{github_ref.gsub(%r{^refs/heads/}, "")}" | ||
| diff_end_sha1 = github_sha | ||
| # Use GitHub Actions variables for branch jobs. |
There was a problem hiding this comment.
Just for future reference: this is the bit that should be fixed for the push job to work.
MikeMcQuaid
approved these changes
Apr 14, 2023
|
Nice work @carlocab! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here,
origin_refpoints to the temporary merge group branch, so itwill be the same as
GITHUB_SHA.