Properly stub resolved bottle filename. #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
reitermarkus
force-pushed
the
stub-filename
branch
from
bbd6f74
to
f3b3846
Compare
reitermarkus
force-pushed
the
stub-filename
branch
from
f3b3846
to
f523a8e
Compare
carlocab
approved these changes
Apr 4, 2023
|
Makes sense, thanks @reitermarkus! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this assumed that the bottle filename was resolved by falling back to the path in the URL, e.g.
0.1.tgzif there was a server error.Fixes the CI error in Homebrew/brew#15117, which makes resolving the file name a hard error in case the server returns e.g. 404.