Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused patches #906

Closed
issyl0 opened this issue Feb 11, 2024 · 3 comments
Closed

Remove unused patches #906

issyl0 opened this issue Feb 11, 2024 · 3 comments

Comments

@issyl0
Copy link
Member

issyl0 commented Feb 11, 2024

Some of the patches here might be unused in core formulae. We should 🚮 the unused ones.

Each patch is referred to by its commit SHA in here so it'll stick around even if removed and our search went wrong somehow and it is still in use.

This could be a GitHub Action, "oi, remove these patches" in this repo or an audit.

issyl0 at pictor in /opt/homebrew/Library/Taps/homebrew/homebrew-core on master
❯ git grep "Homebrew/formula-patches" | uniq | wc -l
     365
@issyl0
Copy link
Member Author

issyl0 commented Feb 11, 2024

Oh, nice, #905 beat me to it!

@SMillerDev
Copy link
Member

Yeah, detection could use some work there if you have some suggestions

Copy link

github-actions bot commented Mar 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Mar 4, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants