Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vlang: vc resource patch #883

Merged
merged 1 commit into from
May 5, 2023
Merged

vlang: vc resource patch #883

merged 1 commit into from
May 5, 2023

Conversation

gromgit
Copy link
Member

@gromgit gromgit commented May 5, 2023

This adds an #include that's needed for macOS Big Sur and below.

@gromgit gromgit mentioned this pull request May 5, 2023
1 task
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we upstreamed this?

This adds an #include that's needed for macOS Big Sur and below.
@carlocab carlocab merged commit 4a51a52 into Homebrew:master May 5, 2023
@gromgit
Copy link
Member Author

gromgit commented May 5, 2023

Not yet. The source file this patch touches is auto-generated from their Linux-related code:

// added by module `os`, file: debugger_linux.c.v:3:
  
#if defined(__has_include)
  
#if __has_include(<sys/ptrace.h>)
#include <sys/types.h>
#include <sys/ptrace.h>
#else
#error VERROR_MESSAGE Header file <sys/ptrace.h>, needed for module `os` was not found. Please install the corresponding development headers.
#endif
  
#else
#include <sys/ptrace.h>
#endif

so the corresponding patch request would touch a completely different file in their mainline.

Also, upstream's recommended build method ("just run make") works perfectly without patches on Big Sur and below, despite building the same files, so it's a bit of a hard ask.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants