Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExtractionSubdirectoryPattern not respected and blank #586

Open
tznind opened this issue Oct 5, 2021 · 1 comment · May be fixed by #614
Open

ExtractionSubdirectoryPattern not respected and blank #586

tznind opened this issue Oct 5, 2021 · 1 comment · May be fixed by #614
Labels
bug Issues that highlight a piece of functionality that is not working as expected its complicated
Projects
Operation Christmas Binary Operation New Year Executable

Comments

@tznind
Copy link
Contributor

tznind commented Oct 5, 2021

Seems to always come out to proj\Extr_id\ regardless though checks work
@tznind tznind added the bug Issues that highlight a piece of functionality that is not working as expected label Oct 5, 2021
@tznind tznind added this to the 7.0 milestone Oct 5, 2021
@tznind tznind removed this from the 7.0 milestone Oct 18, 2021
@tznind
Copy link
Contributor Author

tznind commented Oct 28, 2021 •
edited

Seems that ExtractionDirectory does not consider this setting at all (probably because it doesn't know about Pipelines).

https://github.com/HicServices/RDMP/blob/develop/Rdmp.Core/DataExport/DataExtraction/ExtractionDirectory.cs

ExtractionSubdirectoryPattern functionality was added in 12 Feb 2020 ( 190e1ca )

Frankly I can't see how this ever worked. Everyone and their mother seems to use ExtractionDirectory (release and extract and checks). But given it doesn't get passed an ExtractionDestination we can't respect pipeline settings from that class.

@tznind tznind linked a pull request Dec 13, 2021 that will close this issue
Draft
@RoyMudie RoyMudie mentioned this issue Dec 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues that highlight a piece of functionality that is not working as expected its complicated
Projects
No open projects
Operation Christmas Binary
RDMP Backlog
Operation New Year Executable
Planned
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed ExtractionSubdirectoryPattern HicServices/RDMP
1 participant
@tznind